Biome Format#266
Merged
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 67 67
Lines 763 763
Branches 128 128
=========================================
Hits 763 763 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 55c64ea.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Runs biome format across all packages to standardize code style and ordering.
- Swapped default imports to explicit
typeimports and reordered for consistency - Converted
.forEachloops tofor…ofloops in tests - Normalized
package.jsonarrays and updated import paths (node:specifiers) - Added a local
biome.jsonincreate-sei
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/sei-global-wallet/src/lib/wallet.ts | Switched to type import and reordered members |
| packages/sei-global-wallet/package.json | Normalized typesVersions arrays |
| packages/registry/src/wallets/tests/index.spec.ts | Replaced .forEach with for…of loops, added type |
| packages/registry/src/tokens/index.ts | Changed to import type for Network |
| packages/registry/src/tokens/tests/index.spec.ts | Replaced loops, added type for DenomUnit |
| packages/registry/src/networks/index.ts | Changed to import type for Network |
| packages/registry/src/networks/tests/index.spec.ts | Replaced loops with for…of |
| packages/registry/src/ibc/index.ts | Changed to import type for Network |
| packages/registry/src/ibc/tests/index.spec.ts | Replaced loops with for…of |
| packages/registry/src/gas/index.ts | Changed to import type for Network |
| packages/registry/src/gas/tests/index.spec.ts | Replaced loops with for…of |
| packages/registry/package.json | Normalized files and keywords arrays |
| packages/precompiles/src/ethers/distributionPrecompile.ts | Reordered imported constants |
| packages/precompiles/src/ethers/addressPrecompile.ts | Reordered ethers imports |
| packages/precompiles/package.json | Normalized keywords array |
| packages/ledger/src/cosmos/seiLedgerOfflineAminoSigner.ts | Consolidated type imports |
| packages/ledger/package.json | Normalized files and keywords arrays |
| packages/create-sei/src/main.ts | Updated node: imports, regex, loops, strict equality |
| packages/create-sei/biome.json | Added local Biome config |
Comments suppressed due to low confidence (2)
packages/create-sei/src/main.ts:89
- The updated regex no longer excludes control characters (e.g.,
\x00-\x1F), which can lead to invalid directory names slipping through. Consider re-adding that range to the pattern to block non-printable characters.
const illegalRe = /[<>:"/\\|?*]/g;
packages/create-sei/src/main.ts:98
- [nitpick] This comment is redundant because the subsequent
ifalready covers these checks; you may remove it or update it to explain any non-obvious rationale.
// Check for illegal characters, Windows reserved names, trailing spaces/dots
codebycarson
marked this pull request as ready for review
July 1, 2025 01:13
besated
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs biome format on all directories to make things consistent across PRs and dev environments for future development